Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Blake2s hints (Part 3) #314

Merged
merged 26 commits into from
Nov 21, 2023
Merged

Implement Blake2s hints (Part 3) #314

merged 26 commits into from
Nov 21, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Oct 3, 2023

Depends on #312
Depends on a fix to cairo-vm ✅
cairo-vm version updated ✅

@fmoletta fmoletta changed the base branch from main to blake2s-hints-2 October 3, 2023 19:40
@fmoletta fmoletta marked this pull request as ready for review October 3, 2023 19:42
@fmoletta fmoletta mentioned this pull request Oct 3, 2023
4 tasks
Base automatically changed from blake2s-hints-2 to main October 25, 2023 12:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e01d7a5) 57.48% compared to head (3b603d7) 57.51%.

Files Patch % Lines
pkg/hints/blake2s_hints.go 62.50% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   57.48%   57.51%   +0.03%     
==========================================
  Files          55       55              
  Lines        7145     7179      +34     
==========================================
+ Hits         4107     4129      +22     
- Misses       2625     2633       +8     
- Partials      413      417       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oppen Oppen added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 17a2ee1 Nov 21, 2023
2 checks passed
@Oppen Oppen deleted the blake2s-hints-3 branch November 21, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants