Add traceback to VmException #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
HermanObst,
Jrigada,
Juan-M-V,
Oppen,
entropidelic,
igaray,
juanbono and
pefontana
as code owners
Oppen
approved these changes
Dec 22, 2022
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
Few minor comments but should be good to ship.
src/types/instruction.rs
Outdated
| } | ||
|
|
||
| // Returns True if the given instruction looks like a call instruction. | ||
| pub(crate) fn is_call_instruction(encoded_instruction: &BigInt, imm: Option<BigInt>) -> bool { |
Contributor
There was a problem hiding this comment.
Why is encoded_instruction a BigInt?
Contributor
There was a problem hiding this comment.
Maybe use an Option<&BigInt> for the immediate?
Contributor
Author
There was a problem hiding this comment.
encoded_instruction was left as a BigInt in order to reduce the complexity of get_traceback_entries. is_call_instruction is only used inside get_traceback_entries., which is on the longer side, so it was a bit more convenient to have the type conversion inside the simpler method is_call_instruction
Contributor
Author
There was a problem hiding this comment.
Added reference to immediate argument in is_call_instruction and decode_instruction
1 task
Jrigada
approved these changes
Dec 28, 2022
Oppen
reviewed
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracebackfield toVmExceptionThe following will be added in a later PR:
get_error_attr_valueby adding the methodsubstitute_error_message_references.This PR will not add/process the following information:
This may be added in the future in terms of priority