Skip to content

Add input file contents to traceback #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jan 2, 2023
Merged

Add input file contents to traceback #666

merged 43 commits into from
Jan 2, 2023

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Dec 27, 2022 •
edited
Loading

Depends on #657

  • Add the lines in the source code to the traceback and location
  • Implement Display for Relocatable & MaybeRelocatable
  • Change Debug format to Display format for errors containing Relocatable & MaybeRelocatable

@fmoletta
Start get_traceback_entries + add convenience methos
c47e701
@fmoletta
Add fn is_call_instruction
51219ca
@fmoletta
add code
3b276db
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into traceback
05f0bdd
@fmoletta
Refactor code
c89eb3f
@fmoletta
Clippy
f02db3e
@fmoletta
Add get_traceback method
05813bd
@fmoletta
Fix get_error_attr_value
58992c3
@fmoletta
Add traceback to VmException
b381624
@fmoletta
Make traceback non-optional
936eadc
@fmoletta
Add tests for is_call_instruction
e72dff5
@fmoletta
Add traceback to error display
93eae26
@fmoletta
Add test + fix logic for get_traceback_entries
67ccc39
@fmoletta
Code refactor
ba410b0
@fmoletta
Add one more test for get_traceback_entries
acf3299
@fmoletta
Fix string format + add test for get_traceback
bc66d0f
@fmoletta
Improve fn
b3952cb
@fmoletta
Add reference to is_call_instruction signature
c2fa8a0
@fmoletta
Add reference to immediate in decode_instruction + remove clone
88e4b52
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into traceback
7a03cec
@fmoletta
Fix hint_processor mutability in tests
371dc43
@fmoletta
Add Location::get_location_marks
46a7202
@fmoletta
Fix method to_string_with_contents
fd0b9c6
@fmoletta
Fix string format
5e753bb
@fmoletta
Fix string format
09ee596
@fmoletta
Update traceback tests
9eac613
@fmoletta
Add tests for Location::to_string_with_contents()
3612b01
@fmoletta
Fix intermediate string format
f56122d
@fmoletta
Fix test
00ccd31
@fmoletta
Add tests for Location::get_location_marks()
2ed2287
@fmoletta fmoletta marked this pull request as ready for review December 29, 2022 13:12
This was referenced Dec 29, 2022
Merged
Closed
Jrigada
Jrigada approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Juan-M-V Juan-M-V merged commit c71d95e into main Jan 2, 2023
@Juan-M-V Juan-M-V deleted the input_file_contents branch January 2, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igaray igaray Awaiting requested review from igaray

@Oppen Oppen Awaiting requested review from Oppen

@entropidelic entropidelic Awaiting requested review from entropidelic

@HermanObst HermanObst Awaiting requested review from HermanObst

@juanbono juanbono Awaiting requested review from juanbono

@pefontana pefontana Awaiting requested review from pefontana

2 more reviewers

@Jrigada Jrigada Jrigada approved these changes

@Juan-M-V Juan-M-V Juan-M-V approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmoletta @Jrigada @Juan-M-V