Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove felt new trait #734

Merged
merged 8 commits into from
Jan 20, 2023
Merged

Remove felt new trait #734

merged 8 commits into from
Jan 20, 2023

Conversation

Juan-M-V
Copy link
Contributor

@Juan-M-V Juan-M-V commented Jan 17, 2023 •
edited
Loading

TITLE

Description

Remove FeltNew trait from felt implementation and move new function to FeltOps

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

fmoletta
fmoletta approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Juan-M-V Juan-M-V marked this pull request as draft January 18, 2023 13:15
@Juan-M-V Juan-M-V marked this pull request as ready for review January 18, 2023 14:00
@Juan-M-V Juan-M-V mentioned this pull request Jan 18, 2023
Merged
5 tasks
Jrigada
Jrigada approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juan-M-V Juan-M-V merged commit 9b0b3bd into main Jan 20, 2023
@Juan-M-V Juan-M-V deleted the remove-felt-new-trait branch January 20, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoletta fmoletta fmoletta approved these changes

@Jrigada Jrigada Jrigada approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@juanbono juanbono Awaiting requested review from juanbono juanbono is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juan-M-V @Jrigada @fmoletta