Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Felt to struct and avoid counterintuitive imports #743

Merged
merged 27 commits into from
Jan 20, 2023
Merged

Convert Felt to struct and avoid counterintuitive imports #743

merged 27 commits into from
Jan 20, 2023

Conversation

Juan-M-V
Copy link
Contributor

@Juan-M-V Juan-M-V commented Jan 18, 2023 •
edited
Loading

TITLE

Description

This PR finishes up the work started in #732 and #734 (must be merged after these two). Now the internal felt implementation, FeltBigInt in this case, is completely hidden from the user and its no longer necessary to import the traits NewFelt and FeltOps to use Felt's methods
Resolves: #719

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Juan-M-V Juan-M-V marked this pull request as ready for review January 19, 2023 21:34
juanbono
juanbono approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR fren

Oppen
Oppen requested changes Jan 20, 2023
View reviewed changes
felt/src/lib.rs Outdated Show resolved Hide resolved
felt/src/lib.rs Outdated Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
felt/src/lib.rs Show resolved Hide resolved
@Oppen Oppen merged commit 8f00cc9 into main Jan 20, 2023
@Oppen Oppen deleted the remove-felt-ops-trait branch January 20, 2023 18:53
@fmoletta fmoletta mentioned this pull request Jan 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@Oppen Oppen Oppen approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@Jrigada Jrigada Awaiting requested review from Jrigada

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid leaking bigint representation of the new felt datatype
3 participants
@Juan-M-V @Oppen @juanbono