Refactor verify_secure_runner
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
juanbono
reviewed
Jan 24, 2023
fmoletta
changed the title
verfify_secure_runnerverify_secure_runner
Oppen
reviewed
Jan 24, 2023
Jrigada
approved these changes
Jan 25, 2023
…s/cairo-rs into refactor-verify-secure-runner
Oppen
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_secure_runnerCairoRunner::get_segment_info&BuiltinRunner::get_memory_addressesBuiltinRunner::final_stackinsideCairoRunner::read_return_values(Note: significant refactor needed to fix in a clean way, may affect cairo_rs_py)TODO in a next PR: integrate
verify_secure_runnerintocairo_run