Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BuiltinRunner::final_stack and remove quick fix #778

Merged
merged 12 commits into from
Jan 27, 2023
Merged

Fix BuiltinRunner::final_stack and remove quick fix #778

merged 12 commits into from
Jan 27, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jan 25, 2023 •
edited
Loading

  • Update the builtin's stop_ptr in BuiltinRunner::final_stack
  • Restrict arguments in BuiltinRunner methods from &VirtualMachine to &MemorySegementManager and &Memory to avoid double borrows
  • Remove quick fix from Refactor verify_secure_runner #768
  • Misc: fix BuiltinRunner's included field name

@fmoletta fmoletta marked this pull request as ready for review January 25, 2023 19:37
@fmoletta fmoletta mentioned this pull request Jan 25, 2023
Merged
Oppen
Oppen approved these changes Jan 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@fmoletta @Oppen
Update CHANGELOG.md
116c84c 
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
@fmoletta fmoletta requested a review from HermanObst as a code owner January 25, 2023 20:49
@Jrigada Jrigada merged commit 195f9ce into main Jan 27, 2023
@Jrigada Jrigada deleted the fix-builtin-runner-final-stack branch January 27, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrigada Jrigada Jrigada approved these changes

@Oppen Oppen Oppen approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@juanbono juanbono Awaiting requested review from juanbono juanbono is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@Juan-M-V Juan-M-V Awaiting requested review from Juan-M-V

@HermanObst HermanObst Awaiting requested review from HermanObst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmoletta @Oppen @Jrigada