Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VmException to CairoRunner::run_from_entrypoint #775

Merged
merged 11 commits into from
Jan 27, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jan 25, 2023

  • Change CairoRunner::run_from_entrypoint error return to CairoRunError
  • Convert VirtualMachinErrors returned by CairoRunner::from_until_pc into VmException
  • Add a test to check that errors returned by CairoRunner::run_from_entrypoint contain the appropiate error message attribute when present
  • Make VmException fields public
    Note: Changes in public Api
    Note: CairoRunError currently doesn't implement PartialEq, this will make testing dependant on error variants a bit more tedious

@fmoletta fmoletta changed the title Add vm exception to run from entrypoint Add VmException to CairoRunner::run_from_entrypoint Jan 25, 2023
@fmoletta fmoletta marked this pull request as ready for review January 25, 2023 17:11
@Jrigada Jrigada requested a review from HermanObst as a code owner January 26, 2023 14:54
fmoletta and others added 3 commits January 26, 2023 18:42
@fmoletta fmoletta merged commit 54433e2 into main Jan 27, 2023
@fmoletta fmoletta deleted the add-vm-exception-to-run-from-entrypoint branch January 27, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants