Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

levm: replace gas type from U256 to u64 #1499

Closed
JereSalo opened this issue Dec 12, 2024 · 0 comments · Fixed by #1528
Closed

levm: replace gas type from U256 to u64 #1499

JereSalo opened this issue Dec 12, 2024 · 0 comments · Fixed by #1528
Assignees
@lima-limon-inc
Labels
levm Lambda EVM implementation

Comments

@JereSalo
Copy link
Contributor

Currently we are using U256 for representing gas but the actual type that should be used is u64.
We won't have a problem if we keep on using U256 but u64 is a more convenient type to interact with.
Other things like account balance should stay as U256.
This is not a priority but is something we can do.
@JereSalo JereSalo added the levm Lambda EVM implementation label Dec 12, 2024
@lima-limon-inc lima-limon-inc self-assigned this Dec 18, 2024
This was referenced Dec 18, 2024
Merged
Open
github-merge-queue bot pushed a commit that referenced this issue Dec 20, 2024
@lima-limon-inc
fix(levm): change gas type from U256 to u64 (#1528)
2bb8fa9 
**Motivation**

The execution client uses `u64` for measuring gas, while LEVM uses
`U256`. This PR makes LEVM also use u64 for gas

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #1499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lima-limon-inc lima-limon-inc

Labels
levm Lambda EVM implementation
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(levm): change gas type from U256 to u64 lambdaclass/ethrex
2 participants
@JereSalo @lima-limon-inc