[Tracking] Implement discv4 to connect to p2p peers
#17
Labels
network
Issues related to network communication
Milestone
Comments
Merged
MegaRedHand
changed the title
discv4 to connect to p2p peersdiscv4 to connect to p2p peers
MegaRedHand
added a commit
that referenced
this issue
Jul 3, 2024
**Motivation** According to the spec: > Implementations should ignore any additional elements in the `packet-data` list as well as any extra data after the list. We're currently failing if any of that happens. **Description** This PR introduces `Decoder::finish_unchecked`, which ignores any trailing bytes instead of failing, and uses that to allow for additional elements inside the packet-data. Also, it replaces some usage of `RLPDecode::decode` with `RLPDecode::decode_unfinished` to allow for extra data after the message. As an extra, it refactors out the big `match` inside of both `Message` encode and decode functions, since it's expected those will change often in the next PRs. Related to #17
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this issue
Oct 16, 2024
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this issue
Oct 16, 2024
**Motivation** According to the spec: > Implementations should ignore any additional elements in the `packet-data` list as well as any extra data after the list. We're currently failing if any of that happens. **Description** This PR introduces `Decoder::finish_unchecked`, which ignores any trailing bytes instead of failing, and uses that to allow for additional elements inside the packet-data. Also, it replaces some usage of `RLPDecode::decode` with `RLPDecode::decode_unfinished` to allow for extra data after the message. As an extra, it refactors out the big `match` inside of both `Message` encode and decode functions, since it's expected those will change often in the next PRs. Related to lambdaclass#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need this protocol to be able to connect to peers.
See: https://github.com/ethereum/devp2p/blob/master/discv4.md
Here's a reference implementation: https://github.com/akula-bft/akula/tree/master/src/sentry/devp2p/disc/v4
Related issues:
Pingmessage encoding #74Pingmessage decoding #79Pongmessage encoding #80Pongmessage decoding #81FindNodemessage encoding #82FindNodemessage decoding #83Neighborsmessage encoding #84Neighborsmessage decoding #85ENRRequestmessage encoding #88ENRRequestmessage decoding #89ENRResponsemessage encoding #90ENRResponsemessage decoding #91The text was updated successfully, but these errors were encountered: