fix: ignore extra data in discv4 messages #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
approved these changes
Jul 3, 2024
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
**Motivation** According to the spec: > Implementations should ignore any additional elements in the `packet-data` list as well as any extra data after the list. We're currently failing if any of that happens. **Description** This PR introduces `Decoder::finish_unchecked`, which ignores any trailing bytes instead of failing, and uses that to allow for additional elements inside the packet-data. Also, it replaces some usage of `RLPDecode::decode` with `RLPDecode::decode_unfinished` to allow for extra data after the message. As an extra, it refactors out the big `match` inside of both `Message` encode and decode functions, since it's expected those will change often in the next PRs. Related to lambdaclass#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to the spec:
We're currently failing if any of that happens.
Description
This PR introduces
Decoder::finish_unchecked, which ignores any trailing bytes instead of failing, and uses that to allow for additional elements inside the packet-data. Also, it replaces some usage ofRLPDecode::decodewithRLPDecode::decode_unfinishedto allow for extra data after the message.As an extra, it refactors out the big
matchinside of bothMessageencode and decode functions, since it's expected those will change often in the next PRs.Related to #17