Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEVM: Add support for the stCreate2 test suite #1941

Closed
tomip01 opened this issue Feb 13, 2025 · 0 comments · Fixed by #1942
Closed

LEVM: Add support for the stCreate2 test suite #1941

tomip01 opened this issue Feb 13, 2025 · 0 comments · Fixed by #1942
Assignees
@tomip01
Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation

Comments

@tomip01
Copy link
Contributor

tomip01 commented Feb 13, 2025

After adding the LegacyTest, new folders containing tests for Pre-Cancun forks were added.
Currently the state of folder stCreate2 is:
stCreate2: 126/148 (85.14%).
We want to make it 100%
@tomip01 tomip01 added ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation labels Feb 13, 2025
@tomip01 tomip01 self-assigned this Feb 13, 2025
This was referenced Feb 13, 2025
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2025
@tomip01
fix(levm): add suport for stCreate2 (#1942)
591739c 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->

In this PR we add increase the test passed in the `stCreate2` test suite

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

* We add the correct values for the `ecadd`, `ecmul` and `ecpairing`
precompiles to pre Istanbul forks. This is stated
[here](https://eips.ethereum.org/EIPS/eip-1108)
* We invalidate transactions with the opcode `create2` on forks previous
to Constantinople, see [here](https://eips.ethereum.org/EIPS/eip-1014)

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #1941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomip01 tomip01

Labels
ef-tests Hive tests, execution-spec-tests levm Lambda EVM implementation
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(levm): add suport for stCreate2 lambdaclass/ethrex
1 participant
@tomip01