Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for validating legacy transactions #23

Closed
mpaulucci opened this issue Jun 13, 2024 · 1 comment
Closed

Add support for validating legacy transactions #23

mpaulucci opened this issue Jun 13, 2024 · 1 comment
Assignees
@fmoletta
Labels
state-transition Issues related to execution and state calculation

Comments

@mpaulucci
Copy link
Collaborator

https://docs.infura.io/api/networks/ethereum/concepts/transaction-types

Transactions with type 0x0 are legacy transactions that use the transaction format existing before typed transactions were introduced in EIP-2718. They contain the parameters nonce, gasPrice, gasLimit, to, value, data, v, r, and s. Legacy transactions don’t use access lists or incorporate EIP-1559 fee market changes.
@MegaRedHand MegaRedHand changed the title Add support for executing legacy transactions Add support for validating legacy transactions Jun 14, 2024
@mpaulucci mpaulucci added the state-transition Issues related to execution and state calculation label Jun 18, 2024
@fmoletta fmoletta self-assigned this Jul 10, 2024
@fmoletta fmoletta moved this to Todo in ethrex_l1 Jul 10, 2024
@fmoletta fmoletta mentioned this issue Jul 10, 2024
Closed
@fmoletta fmoletta moved this from Todo to In Progress in ethrex_l1 Jul 10, 2024
@fmoletta fmoletta moved this from In Progress to In Review in ethrex_l1 Jul 10, 2024
@fmoletta fmoletta mentioned this issue Jul 11, 2024
Merged
@fmoletta
Copy link
Contributor

Closed by: #73 as evm already performs validations before executing

@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmoletta fmoletta

Labels
state-transition Issues related to execution and state calculation
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: tx validation for legacy txs lambdaclass/ethrex
2 participants
@mpaulucci @fmoletta