Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add error handling to evm module #142

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jul 11, 2024

Motivation

Add error handling to execute_tx and remove unwrap

Description

Add EvmError
Map revm's EVMError to EvmError
Add error handling to execute_tx

Closes None

@fmoletta fmoletta marked this pull request as ready for review July 11, 2024 15:23
@fmoletta fmoletta requested a review from a team as a code owner July 11, 2024 15:23
@fmoletta fmoletta changed the title feat: use evm preverify_transaction + add error handling feat: add error handling to evm module Jul 11, 2024
@fmoletta fmoletta changed the title feat: add error handling to evm module refactor: add error handling to evm module Jul 11, 2024
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@MegaRedHand MegaRedHand merged commit 9d9ab65 into main Jul 12, 2024
3 checks passed
@MegaRedHand MegaRedHand deleted the add-evm-preverify branch July 12, 2024 14:34
mpaulucci pushed a commit to mpaulucci/lambda_ethereum_rust that referenced this pull request Oct 16, 2024
**Motivation**

Add error handling to `execute_tx` and remove unwrap
<!-- Why does this pull request exist? What are its goals? -->

**Description**

Add `EvmError`
Map revm's `EVMError` to `EvmError`
Add error handling to `execute_tx`

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->

Closes  None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants