feat: integrate revm + impl address recovery #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Jun 28, 2024
mpaulucci
reviewed
Jun 28, 2024
| @@ -1,14 +1,99 @@ | |||
| pub fn add(left: usize, right: usize) -> usize { | |||
There was a problem hiding this comment.
I think we wanted to avoid to many crates so we were adding evm code to core.
mpaulucci
reviewed
Jun 28, 2024
mpaulucci
reviewed
Jun 28, 2024
crates/evm/src/lib.rs
Outdated
| let acc_info = RevmAccountInfo { | ||
| balance: U256::from_limbs(account.info.balance.0), | ||
| code_hash: account.info.code_hash.0.into(), | ||
| code: Some(Bytecode::new_raw(account.code.clone().into())), |
There was a problem hiding this comment.
code it optional right? Depending on if the address is a smart contract or a EOA?
|
sorry, didn't realize this was a draft 😅 |
…d of genesis block
MegaRedHand
reviewed
Jul 1, 2024
juanbono
reviewed
Jul 1, 2024
juanbono
reviewed
Jul 1, 2024
juanbono
reviewed
Jul 1, 2024
juanbono
reviewed
Jul 1, 2024
mpaulucci
reviewed
Jul 2, 2024
juanbono
approved these changes
Jul 2, 2024
This was referenced Jul 11, 2024
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
**Motivation** Replace evm code in eftests with an implementation that uses ethrex types **Description** * Implement `execute_tx` using revm * Move `evm` crate into `core` crate * Move `Transaction` into its own module * Implement multiple getters for `Transaction` fields * Implement address recovery from signed transactions * Implement conversions between ef tests types and ethrex types * Add one more ef test <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes lambdaclass#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace evm code in eftests with an implementation that uses ethrex types
Description
execute_txusing revmevmcrate intocorecrateTransactioninto its own moduleTransactionfieldsCloses #21