Remove TotalDifficulty from RpcBlock
#307
Comments
avilagaston9
added a commit
that referenced
this issue
Aug 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 26, 2024
**Motivation** We are currently not matching the expected response from Hive on the `eth_getBlockByHash` endpoint. **Description** - Moves `BlockSerializable` to the RPC module. - Renames `BlockSerializable` to `RpcBlock`. - Creates `FullBlockBody` which holds `RpcTransaction` instead of `Transaction` to match the Hive expected output. - Adds logic to calculate `TotalDifficulty` of blocks. **Observations** #307 was created to remove `TotalDifficulty` calculation logic added by this PR. This is because this field it is not being used since the merge, but it is still required to pass Hive tests. Closes #269
|
to fix your trouble try download this fix, i see it in another issue, |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 5, 2024
**Motivation** After the merge, `totalDifficulty` no longer plays any role in the core protocol's operation. We were maintaining it solely to pass Hive tests. **Description** Removes `totalDifficulty` from our codebase. Closes #307
|
We are adding this field back in #566 as we need it to run hive engine tests. |
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this issue
Oct 16, 2024
**Motivation** We are currently not matching the expected response from Hive on the `eth_getBlockByHash` endpoint. **Description** - Moves `BlockSerializable` to the RPC module. - Renames `BlockSerializable` to `RpcBlock`. - Creates `FullBlockBody` which holds `RpcTransaction` instead of `Transaction` to match the Hive expected output. - Adds logic to calculate `TotalDifficulty` of blocks. **Observations** lambdaclass#307 was created to remove `TotalDifficulty` calculation logic added by this PR. This is because this field it is not being used since the merge, but it is still required to pass Hive tests. Closes lambdaclass#269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See ethereum/execution-apis#570.
We are currently including
TotalDifficultyin RPC block requests solely to match Hive tests. This should be removed once it is deprecated.The text was updated successfully, but these errors were encountered: