fix: remove totalDifficulty #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
added a commit
that referenced
this pull request
Sep 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
**Motivation** <!-- Why does this pull request exist? What are its goals? --> While the rpc-compat tests can be made to work without the totalDifficulty field by updating the execution api crate, the engine tests panick as they still rely on it. This PR aims to fix this issue (at least until the hive engine test suite is updated) by reverting the removal of the field and using a previous version of the execution api crate which still has this field <!-- A clear and concise general description of the changes this PR introduces --> * Reverts #347 * Updates hive rev to a version using a previous version of execution-apis that still uses the totalDifficulty field (lambdaclass/hive#6) <!-- Link to issues: Resolves #111, Resolves #222 --> Closes None, but is needed in order to run engine tests
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
**Motivation** After the merge, `totalDifficulty` no longer plays any role in the core protocol's operation. We were maintaining it solely to pass Hive tests. **Description** Removes `totalDifficulty` from our codebase. Closes lambdaclass#307
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
…ass#566) **Motivation** <!-- Why does this pull request exist? What are its goals? --> While the rpc-compat tests can be made to work without the totalDifficulty field by updating the execution api crate, the engine tests panick as they still rely on it. This PR aims to fix this issue (at least until the hive engine test suite is updated) by reverting the removal of the field and using a previous version of the execution api crate which still has this field <!-- A clear and concise general description of the changes this PR introduces --> * Reverts lambdaclass#347 * Updates hive rev to a version using a previous version of execution-apis that still uses the totalDifficulty field (lambdaclass/hive#6) <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes None, but is needed in order to run engine tests
mpaulucci
pushed a commit
to mpaulucci/lambda_ethereum_rust
that referenced
this pull request
Oct 16, 2024
…ass#566) **Motivation** <!-- Why does this pull request exist? What are its goals? --> While the rpc-compat tests can be made to work without the totalDifficulty field by updating the execution api crate, the engine tests panick as they still rely on it. This PR aims to fix this issue (at least until the hive engine test suite is updated) by reverting the removal of the field and using a previous version of the execution api crate which still has this field <!-- A clear and concise general description of the changes this PR introduces --> * Reverts lambdaclass#347 * Updates hive rev to a version using a previous version of execution-apis that still uses the totalDifficulty field (lambdaclass/hive#6) <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes None, but is needed in order to run engine tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the merge,
totalDifficultyno longer plays any role in the core protocol's operation. We were maintaining it solely to pass Hive tests.Description
Removes
totalDifficultyfrom our codebase.Closes #307