feat(levm): add precompiled contracts addresses to cache #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
reviewed
Dec 11, 2024
Comment on lines
+152
to
+155
| for i in 1..10 { | ||
| default_touched_accounts.insert(Address::from_low_u64_be(i)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can't we iterate the constant we have in precompiles.rs with the list of precompile addresses?
There was a problem hiding this comment.
Added this as a to-do comment in Add todo coment
ilitteri
reviewed
Dec 11, 2024
| @@ -138,6 +138,7 @@ impl VM { | |||
|
|
|||
| let mut default_touched_storage_slots: HashMap<Address, HashSet<H256>> = HashMap::new(); | |||
|
|
|||
| // Add access lists contents to cache | |||
There was a problem hiding this comment.
Is this meant for this PR?
There was a problem hiding this comment.
It's not strictly related, but makes more understandable the code IMO
JereSalo
deleted the
levm/feat/add-precompiled-contracts-addresses-to-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Precompiles are not implemented yet, but some tests test sideways those addresses are cached, so this makes those tests (8 tests) pass.
Description
Just adds addresses between 1 and 9 to the cached addresses.