Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(levm): add precompiled contracts addresses to cache #1473

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat(levm): add precompiled contracts addresses to cache #1473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb7db80
Add precompile contracts addresses to cached ones
maximopalopoli Dec 11, 2024
26f280e
Add comments to clarify
maximopalopoli Dec 11, 2024
02226e4
Add todo coment
maximopalopoli Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/vm/levm/src/vm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ impl VM {

let mut default_touched_storage_slots: HashMap<Address, HashSet<H256>> = HashMap::new();

// Add access lists contents to cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not strictly related, but makes more understandable the code IMO

for (address, keys) in access_list.clone() {
default_touched_accounts.insert(address);
let mut warm_slots = HashSet::new();
Expand All @@ -147,6 +148,12 @@ impl VM {
default_touched_storage_slots.insert(address, warm_slots);
}

// Add precompiled contracts addresses to cache.
// TODO: Use the addresses from precompiles.rs in a future
for i in 1..10 {
default_touched_accounts.insert(Address::from_low_u64_be(i));
}

Comment on lines +153 to +156
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we iterate the constant we have in precompiles.rs with the list of precompile addresses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this as a to-do comment in Add todo coment

match to {
TxKind::Call(address_to) => {
default_touched_accounts.insert(address_to);
Expand Down
Loading