ci(l1): use ethereum/hive for rpc-compat simulation.
#4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from a custom lambdaclass/hive fork to the official ethereum/hive repository for RPC compatibility simulation tests. The change involves updating repository references and implementing build argument support to pin a specific version of execution-apis for testing consistency.
- Updated all test configurations to use the official ethereum/hive repository instead of the fork
- Added build argument functionality to pin execution-apis to a specific commit for RPC compatibility tests
- Standardized all hive version references to a single commit hash across all test configurations
Comments suppressed due to low confidence (1)
.github/workflows/pr-main_l1.yaml:1
- The removal of the
limitparameter for RPC compatibility tests removes the specific test filtering that was previously in place. This could lead to running more tests than intended or different test coverage. Consider documenting why the limit was removed or if it should be replaced with equivalent filtering.
name: L1
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| limit: "rpc-compat/(debug_[^/]+/.*|eth_blobBaseFee/.*|eth_blockNumber/.*|eth_call/.*|eth_chainId/.*|eth_createAccessList/.*|eth_estimateGas/.*|eth_feeHistory/.*|eth_getBalance/.*|eth_getBlockByHash/.*|eth_getBlockByNumber/.*|eth_getBlockReceipts/.*|eth_getBlockTransactionCountByHash/.*|eth_getBlockTransactionCountByNumber/.*|eth_getCode/.*|eth_getLogs/.*|eth_getProof/.*|eth_getStorageAt/.*|eth_getTransactionByBlockHashAndIndex/.*|eth_getTransactionByBlockNumberAndIndex/.*|eth_getTransactionByHash/.*|eth_getTransactionCount/.*|eth_getTransactionReceipt/.*|eth_sendRawTransaction/.*)" | ||
| hive_repository: lambdaclass/hive | ||
| hive_version: 115f4d6ef1bdd2bfcabe29ec60424f6327e92f43 | ||
| # https://github.com/ethereum/execution-apis/pull/627 changed the simulation to use a pre-merge genesis block, so we need to pin to a commit before that |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ilitteri
approved these changes
Oct 15, 2025
rodrigo-o
reviewed
Oct 15, 2025
| hive_repository: lambdaclass/hive | ||
| hive_version: 115f4d6ef1bdd2bfcabe29ec60424f6327e92f43 | ||
| # https://github.com/ethereum/execution-apis/pull/627 changed the simulation to use a pre-merge genesis block, so we need to pin to a commit before that | ||
| buildarg: "branch=d08382ae5c808680e976fce4b73f4ba91647199b" |
There was a problem hiding this comment.
This extra argument has something to do with the rpc-compat suite passing in hive?
There was a problem hiding this comment.
yes, see ethereum/hive#1354
rodrigo-o
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To not use our hive fork anymore
Description
With this ethereum/hive#1354 we can pin the https://github.com/ethereum/execution-apis.git version, and we will pin it to a commit that contains a post-merge commit