fix(l1, l2): tuning parameters of qfilter #5166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the initial capacity of the trie layering bloom filter from 100,000 to 1,000,000 entries, representing a 10x increase to better accommodate larger workloads.
- Adjusted the initial capacity parameter of the bloom filter from 100,000 to 1,000,000
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| impl TrieLayerCache { | ||
| // TODO: tune this |
There was a problem hiding this comment.
The create_filter function has a TODO comment indicating these parameters need tuning. With this significant 10x increase in initial capacity, consider documenting the rationale for this specific value (e.g., based on observed workload patterns or performance testing) to help future maintainers understand why 1,000,000 was chosen and when it might need adjustment.
Suggested change
| // TODO: tune this | |
| // Initial capacity set to 1,000,000 to accommodate expected high volume of keys per observed workload patterns. | |
| // This is a 10x increase over typical defaults, based on performance testing to minimize false positives and | |
| // avoid frequent resizing. Future maintainers should revisit this value if workload characteristics change, | |
| // or if memory usage/performance becomes a concern. See issue #1234 for tuning discussion. |
jrchatruc
changed the title
jrchatruc
approved these changes
Nov 3, 2025
MegaRedHand
approved these changes
Nov 3, 2025
Lines of code reportTotal lines added: Detailed view |
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** Bloom filter was set in a small capacity. **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bloom filter was set in a small capacity.
Description
Closes #issue_number