Skip to content

fix: new ssz fixes for the static spec-test #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Apr 15, 2025

Motivation

After #1427 nearly 1500 test were failing due to ssz issues

Description

This PR makes a small changing adding the new containers to the schema_match macro that were missing them.

Before this PR:
11370 tests, 2003 failures, 784 skipped

After this PR:
11370 tests, 979 failures, 784 skipped

Resolves part of #1429

@rodrigo-o rodrigo-o changed the base branch from main to electra-support April 15, 2025 16:08
@rodrigo-o rodrigo-o marked this pull request as ready for review April 15, 2025 19:30
@rodrigo-o rodrigo-o requested a review from a team as a code owner April 15, 2025 19:30
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rodrigo-o rodrigo-o merged commit bcc7782 into electra-support Apr 15, 2025
18 of 22 checks passed
@rodrigo-o rodrigo-o deleted the new-ssz-fixes-for-spec-test branch April 15, 2025 19:33
rodrigo-o added a commit that referenced this pull request Apr 16, 2025
rodrigo-o added a commit that referenced this pull request Apr 25, 2025
rodrigo-o added a commit that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Validate the newly un-skipped spec-test in electra
2 participants