fix: outstanding ssz issues after #1430 #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
LeanSerra
approved these changes
Apr 15, 2025
This was referenced Apr 16, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are still 492 ssz related test failing in the spec test suite after #1430.
Description
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH) which was out of sync since deneb.MAX_BLOB_COMMITMENTS_PER_BLOCK) which was out of sync since deneb.A couple of other test have been also fixed by this changes
Before this PR:
11370 tests, 979 failures, 784 skippedAfter this PR:
11370 tests, 424 failures, 784 skippedCloses #1429