This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Refactor transaction module #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction-module-refactor
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 50 50
Lines 10043 10043
=======================================
Hits 9038 9038
Misses 1005 1005
|
…ransaction-module-refactor
juanbono
reviewed
Jun 6, 2023
bench/internals.rs
Outdated
| internal_declare::InternalDeclare, internal_deploy::InternalDeploy, | ||
| internal_deploy_account::InternalDeployAccount, | ||
| internal_invoke_function::InternalInvokeFunction, | ||
| transaction::{ |
There was a problem hiding this comment.
I think it would be nice to re-export the transaction types in the transaction/mod.rs file so we can import them like this:
use transaction::{Deploy, Declare, DeployAccount, InvokeFunction};
juanbono
approved these changes
Jun 6, 2023
xqft
approved these changes
Jun 6, 2023
Oppen
approved these changes
Jun 6, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #587