Consider missing indices in PropertyGenerator #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Apr 23, 2021
Ocramius
requested changes
Apr 23, 2021
Signed-off-by: Thomas Rieschl <thomas@trinet.at>
rieschl
force-pushed
the
fix/notice-typed-property
branch
from
fa9d202 to
0872dbd
Compare
|
This bug is also in the 3.x branch (checked with 3.4.1). Do I have to submit a patch for this version, too? |
IMO no need, unless it it a security issue (not the case - codegen is not supposed to be built upon user input) |
|
Thanks @rieschl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing array index
E_NOTICEerror inPropertyGenerator.fixes #76
Edit: The test explicitly checks, that typed properties will be ignored when generating the code. Maybe that feature should be implemented in a future release, and that will cause this test to fail.