-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.3 #49
Conversation
Looks like the |
They are optional, indeed. |
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Yeah, I agree with testing with the extensions. I meant to also test without the extensions to see if the rest of the library properly works when the optional extensions are not installed. |
Thats definitely something we could do, but that would most likely require to re-configure the checks made by this project. Might be more beneficial if we simply ignore uninstallable extensions instead of failing hard. Can you create a feature request in the CI container action? That would be helpful, I'll manage to make the tests pass. |
sury does not (yet) provide those extensions and thus we have to install them via PECL as a fallback. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Ref: https://wiki.php.net/rfc/unserialize_warn_on_trailing_data Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Thanks, @MauricioFauth! |
Description
Adds support for PHP 8.3.