Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move CellxGene Curator from cellxgene-lamin here #2403

Merged
merged 14 commits into from
Jan 30, 2025
Merged

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jan 29, 2025

Is part of a sequence of PRs that refactors the curators:

This PR merely moves code without yet refactoring it.

It moves the CellxGeneCurator from cellxgene_lamin here and it moves the SpatialDataCurator from the separate file curators._spatial.py into curators/__init__.py.

This is to prepare a joint refactor of all Curator classes.

See the corresponding PR in cellxgene-lamin:

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 64.07186% with 120 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (d503387) to head (8c6288e).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/curators/__init__.py 64.81% 114 Missing ⚠️
lamindb/curators/_cellxgene_schemas/__init__.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   91.71%   90.86%   -0.86%     
==========================================
  Files          62       62              
  Lines        9138     9422     +284     
==========================================
+ Hits         8381     8561     +180     
- Misses        757      861     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 29, 2025

@github-actions github-actions bot temporarily deployed to pull request January 29, 2025 16:00 Inactive
@falexwolf falexwolf changed the title Curators ♻️ Refactor curators Jan 29, 2025
@falexwolf falexwolf changed the title ♻️ Refactor curators 🚚 Move cellxgene curator here Jan 29, 2025
@falexwolf falexwolf changed the title 🚚 Move cellxgene curator here 🚚 Move CellXGene Curator from cellxgene-lamin here Jan 30, 2025
@github-actions github-actions bot temporarily deployed to pull request January 30, 2025 07:55 Inactive
@Koncopd
Copy link
Member

Koncopd commented Jan 30, 2025

Why don't we split the gigantic __init__.py for curators?

@falexwolf
Copy link
Member Author

falexwolf commented Jan 30, 2025

Why don't we split the gigantic init.py for curators?

To prepare a refactor. And I find it much easier to enforce consistency if there is one file with a couple thousand lines of the same class over and over than this being spread out across different fiiles.

@falexwolf falexwolf merged commit a10fefc into main Jan 30, 2025
4 of 15 checks passed
@falexwolf falexwolf deleted the curators branch January 30, 2025 13:01
@falexwolf falexwolf changed the title 🚚 Move CellXGene Curator from cellxgene-lamin here 🚚 Move CellxGene Curator from cellxgene-lamin here Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants