-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚚 Move CellxGene
Curator
from cellxgene-lamin
here
#2403
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
- Coverage 91.71% 90.86% -0.86%
==========================================
Files 62 62
Lines 9138 9422 +284
==========================================
+ Hits 8381 8561 +180
- Misses 757 861 +104 ☔ View full report in Codecov by Sentry. |
Curator
from cellxgene-lamin
here
Why don't we split the gigantic |
To prepare a refactor. And I find it much easier to enforce consistency if there is one file with a couple thousand lines of the same class over and over than this being spread out across different fiiles. |
Curator
from cellxgene-lamin
hereCellxGene
Curator
from cellxgene-lamin
here
Is part of a sequence of PRs that refactors the curators:
PertCurator
fromwetlab
here and addCellxGene
Curator
test #2408DataFrameCurator
#2388This PR merely moves code without yet refactoring it.
It moves the
CellxGeneCurator
fromcellxgene_lamin
here and it moves theSpatialDataCurator
from the separate filecurators._spatial.py
intocurators/__init__.py
.This is to prepare a joint refactor of all
Curator
classes.See the corresponding PR in
cellxgene-lamin
:Curator
tolamindb
cellxgene-lamin#120