🚚 Bulk-rename old-style curators to CatCurator
#2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2025
falexwolf
changed the title
CatCuratorCatCurator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 91.71% 91.34% -0.37%
==========================================
Files 62 62
Lines 9138 9652 +514
==========================================
+ Hits 8381 8817 +436
- Misses 757 835 +78 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of a sequence of PRs that refactors the curators:
using_keyin curators #2414CellxGeneschema #2412PertCuratorfromwetlabhere and addCellxGeneCuratortest #2408CellxGeneCuratorfromcellxgene-laminhere #2403DataFrameCurator#2388This PR establishes the
Cat-prefixed naming convention for all old-style curators that was adopted in the PR:DataFrameCurator#2388This will make it easier to re-use the existing code in the background, ensuring backward compat, while launching the new-style curators for users.