Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix GLIBC version not found in java maven jar #2613

Closed
wants to merge 8 commits into from

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Jul 18, 2024

Revert nodejs version back to 16 to avoid GLIBC version not found issue in ubuntu and other OS.
Starting from nodejs 18, it requires a much higher GLIBC version and will prevent the application from starting if fail the check.

@LuQQiu LuQQiu requested a review from eddyxu July 18, 2024 17:01
@github-actions github-actions bot added the bug Something isn't working label Jul 18, 2024
@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jul 18, 2024

@eddyxu PTAL, i cancelled the workflow since it will actually release to maven.
If the changes look good, i will update the maven version to 0.0.5 and let the pipeline runs

Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a 0.0.5 test release to see whether it solve the problem

@github-actions github-actions bot added the java label Jul 22, 2024
@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jul 22, 2024

Run echo "use-agent" >> ~/.gnupg/gpg.conf
/home/runner/work/_temp/e0369203-8970-4980-8b5c-b283201cd97a.sh: line 1: /home/runner/.gnupg/gpg.conf: No such file or directory
Error: Process completed with exit code 1.

The setup-java didn't set up gpg correctly

Run actions/setup-java@v4
  with:
    distribution: temurin
    java-version: 8
    cache: maven
    server-id: ossrh
    server-username: SONATYPE_USER
    server-password: SONATYPE_TOKEN
    java-package: jdk
    check-latest: false
    overwrite-settings: true
    job-status: success
    token: ***

The previous successful one shows

Run actions/setup-java@v4
  with:
    distribution: temurin
    java-version: 8
    cache: maven
    server-id: ossrh
    server-username: SONATYPE_USER
    server-password: SONATYPE_TOKEN
    gpg-private-key: ***
    gpg-passphrase: ***
    java-package: jdk
    check-latest: false
    overwrite-settings: true
    job-status: success
    token: ***

@LuQQiu LuQQiu closed this Jul 26, 2024
@@ -40,6 +44,10 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Node.js 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently this fixes the GLIBC version issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the glibc issue in older ubuntu version, ubuntu version <= 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants