Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix GLIBC version not found in java maven jar #2613

Closed
wants to merge 8 commits into from
Closed

fix: fix GLIBC version not found in java maven jar #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31e7449
Revert nodejs back to version 16
LuQQiu Jul 18, 2024
d1c813f
Merge branch 'main' of github.com:lancedb/lance into fixNode
LuQQiu Jul 22, 2024
7820c5a
Update to 0.0.5 version
LuQQiu Jul 22, 2024
a721188
Move node to after java
LuQQiu Jul 22, 2024
b6a1b9c
Ensure gpg.conf exist
LuQQiu Jul 23, 2024
ac56e7c
Use env for retrieve secrets
LuQQiu Jul 24, 2024
0ca3a2f
try
LuQQiu Jul 24, 2024
c4e629f
Merge branch 'main' of github.com:lancedb/lance into fixNode
LuQQiu Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions .github/workflows/java-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
- name: Set up Node.js 16
uses: actions/setup-node@v4
with:
node-version: '16'
- name: Install dependencies
run: |
brew install protobuf
Expand All @@ -40,6 +44,10 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Node.js 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently this fixes the GLIBC version issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the glibc issue in older ubuntu version, ubuntu version <= 20

uses: actions/setup-node@v4
with:
node-version: '16'
- uses: Swatinem/rust-cache@v2
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
Expand Down Expand Up @@ -82,8 +90,17 @@ jobs:
server-id: ossrh
server-username: SONATYPE_USER
server-password: SONATYPE_TOKEN
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }}
gpg-private-key: MAVEN_GPG_PRIVATE_KEY
gpg-passphrase: MAVEN_GPG_PASSPHRASE
env:
SONATYPE_USER: ${{ secrets.SONATYPE_USER }}
SONATYPE_TOKEN: ${{ secrets.SONATYPE_TOKEN }}
MAVEN_GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
- name: Set up Node.js 16
uses: actions/setup-node@v4
with:
node-version: '16'
- name: Install dependencies
run: |
sudo apt -y -qq update
Expand All @@ -101,10 +118,27 @@ jobs:
git config --global user.name "dev+gha@lancedb.com"
- name: Publish with Java 8
run: |
mkdir -p ~/.gnupg
touch ~/.gnupg/gpg.conf
echo "use-agent" >> ~/.gnupg/gpg.conf
echo "pinentry-mode loopback" >> ~/.gnupg/gpg.conf
export GPG_TTY=$(tty)
mvn --batch-mode -DskipTests -DpushChanges=false -Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }} deploy -P deploy-to-ossrh
env:
SONATYPE_USER: ${{ secrets.SONATYPE_USER }}
SONATYPE_TOKEN: ${{ secrets.SONATYPE_TOKEN }}
MAVEN_GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
- name: Find Spark Jar
run: |
RELATIVE_JAR_PATH=$(find spark/target -name 'lance-spark-2.12-*-jar-with-dependencies.jar')
JAR_NAME=$(basename $RELATIVE_JAR_PATH)
JAR_PATH=$(readlink -f "$RELATIVE_JAR_PATH")
echo "SPARK_JAR_PATH=$JAR_PATH" >> $GITHUB_ENV
echo "SPARK_JAR_NAME=$JAR_NAME" >> $GITHUB_ENV
- uses: actions/upload-artifact@v4
with:
name: ${{ env.SPARK_JAR_NAME }}
path: ${{ env.SPARK_JAR_PATH }}
retention-days: 7
if-no-files-found: error
2 changes: 1 addition & 1 deletion java/core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>com.lancedb</groupId>
<artifactId>lance-parent</artifactId>
<version>0.0.4</version>
<version>0.0.5</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.lancedb</groupId>
<artifactId>lance-parent</artifactId>
<version>0.0.4</version>
<version>0.0.5</version>
<packaging>pom</packaging>

<name>Lance Parent</name>
Expand Down
4 changes: 2 additions & 2 deletions java/spark/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>com.lancedb</groupId>
<artifactId>lance-parent</artifactId>
<version>0.0.4</version>
<version>0.0.5</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -40,7 +40,7 @@
<dependency>
<groupId>com.lancedb</groupId>
<artifactId>lance-core</artifactId>
<version>0.0.4</version>
<version>0.0.5</version>
</dependency>
<dependency>
<groupId>org.apache.spark</groupId>
Expand Down
Loading