Make lando db-export use mariadb-dump, if it exists
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mysqldump` is deprecated in current versions of MariaDB, and generates a deprecation warning. This change allows `db-export` to use `mariadb-dump` if that command exists and the `MARIADB_DATABASE` env var is set. Resolves lando/mariadb#47
❌ Deploy Preview for lando-core failed. Why did it fail? →
|
9 tasks
pirog
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Make `lando db-export` use mariadb-dump, if exists `mysqldump` is deprecated in current versions of MariaDB, and generates a deprecation warning. This change allows `db-export` to use `mariadb-dump` if that command exists and the `MARIADB_DATABASE` env var is set. Resolves lando/mariadb#47 * Fix typo in sql-export.sh comment * Update CHANGELOG. --------- Co-authored-by: Alec Reynolds <alec+git@lando.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqldumpis deprecated in current versions of MariaDB, andlando db-exportgenerates a deprecation warning in these versions. This change allowsdb-exportto usemariadb-dumpif that command exists and theMARIADB_DATABASEenv var is set.Resolves lando/mariadb#47.
Instead of worrying about which versions of MariaDB use the new command, I'm checking if the command exists and using it if it does.
I have created a test for the MariaDB service.