-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MariaDB 11 deprecates mysqldump, need an option to use else in lando db-export and lando db-import scripts #47
Comments
Thanks for bringing this up @kaszarobert! This looks like a great contributor issue. Right now the db-export/import commands are managed from scripts in We'd probably just need to add an additional condition for Mariadb (like we do for Postgres). I think this is a problem restricted to Lando v3, but even though the changes will be to |
`mysqldump` is deprecated in current versions of MariaDB, and generates a deprecation warning. This change allows `db-export` to use `mariadb-dump` if that command exists and the `MARIADB_DATABASE` env var is set. Resolves lando/mariadb#47
This is a test for a proposed change to lando/core, to address lando#47.
* Make `lando db-export` use mariadb-dump, if exists `mysqldump` is deprecated in current versions of MariaDB, and generates a deprecation warning. This change allows `db-export` to use `mariadb-dump` if that command exists and the `MARIADB_DATABASE` env var is set. Resolves lando/mariadb#47 * Fix typo in sql-export.sh comment * Update CHANGELOG. --------- Co-authored-by: Alec Reynolds <alec+git@lando.dev>
* Add test case for mysqldump deprecation This is a test for a proposed change to lando/core, to address #47. * Improve mysqldump deprecation test Make better use of `grep` in the test, and direct output of dump command to STDOUT so the test doesn't generate export files. * #47: Test a db-export type tooling command. * #47: Make sure we actually add the test. * #47: Better name for the test. * Make checklinks happy. * Make checklinks happy. --------- Co-authored-by: Alec Reynolds <alec+git@lando.dev>
* Make `lando db-export` use mariadb-dump, if exists `mysqldump` is deprecated in current versions of MariaDB, and generates a deprecation warning. This change allows `db-export` to use `mariadb-dump` if that command exists and the `MARIADB_DATABASE` env var is set. Resolves lando/mariadb#47 * Fix typo in sql-export.sh comment * Update CHANGELOG. --------- Co-authored-by: Alec Reynolds <alec+git@lando.dev>
If you force Lando to use image
bitnami/mariadb:11.0.5-debian-12-r5
for database service, runninglando db-export
andlando db-import
shows this on CLI:It runs fine right now, you just meet with deprecation messages. But in the future it could no longer work for MariaDB, so we need a way to switch to '/opt/bitnami/mariadb/bin/mariadb-dump' instead for MariaDB 11+.
The text was updated successfully, but these errors were encountered: