-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harrison/add docs #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashesy
added a commit
to dashesy/langchain
that referenced
this pull request
Mar 31, 2023
Simplify to always try to start with "objects" task, to avoid using image name as a valid tag Start with OCR if it is a pdf Tweak for photo editing
hwchase17
pushed a commit
that referenced
this pull request
Apr 27, 2023
without --no-sandbox param, load documents from url by selenium in chrome occured error below: ```Traceback (most recent call last): File "/data//playgroud/try_langchain.py", line 343, in <module> langchain_doc_loader() File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader documents = loader.load() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load driver = self._get_driver() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver return Chrome(options=chrome_options) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__ self.start_session(capabilities, browser_profile) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session response = self.execute(Command.NEW_SESSION, parameters) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute self.error_handler.check_response(response) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally. (unknown error: DevToolsActivePort file doesn't exist) (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) Stacktrace: #0 0x55cf8da1bfe3 <unknown> #1 0x55cf8d75ad36 <unknown> #2 0x55cf8d783b20 <unknown> #3 0x55cf8d77fa9b <unknown> #4 0x55cf8d7c1af7 <unknown> #5 0x55cf8d7c111f <unknown> #6 0x55cf8d7b8693 <unknown> #7 0x55cf8d78b03a <unknown> #8 0x55cf8d78c17e <unknown> #9 0x55cf8d9dddbd <unknown> #10 0x55cf8d9e1c6c <unknown> #11 0x55cf8d9eb4b0 <unknown> #12 0x55cf8d9e2d63 <unknown> #13 0x55cf8d9b5c35 <unknown> #14 0x55cf8da06138 <unknown> #15 0x55cf8da062c7 <unknown> #16 0x55cf8da14093 <unknown> #17 0x7f3da31a72de start_thread ``` add option `chrome_options.add_argument("--no-sandbox")` for chrome.
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
without --no-sandbox param, load documents from url by selenium in chrome occured error below: ```Traceback (most recent call last): File "/data//playgroud/try_langchain.py", line 343, in <module> langchain_doc_loader() File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader documents = loader.load() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load driver = self._get_driver() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver return Chrome(options=chrome_options) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__ self.start_session(capabilities, browser_profile) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session response = self.execute(Command.NEW_SESSION, parameters) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute self.error_handler.check_response(response) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally. (unknown error: DevToolsActivePort file doesn't exist) (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) Stacktrace: #0 0x55cf8da1bfe3 <unknown> #1 0x55cf8d75ad36 <unknown> #2 0x55cf8d783b20 <unknown> #3 0x55cf8d77fa9b <unknown> #4 0x55cf8d7c1af7 <unknown> #5 0x55cf8d7c111f <unknown> #6 0x55cf8d7b8693 <unknown> #7 0x55cf8d78b03a <unknown> #8 0x55cf8d78c17e <unknown> #9 0x55cf8d9dddbd <unknown> #10 0x55cf8d9e1c6c <unknown> #11 0x55cf8d9eb4b0 <unknown> #12 0x55cf8d9e2d63 <unknown> #13 0x55cf8d9b5c35 <unknown> #14 0x55cf8da06138 <unknown> #15 0x55cf8da062c7 <unknown> #16 0x55cf8da14093 <unknown> #17 0x7f3da31a72de start_thread ``` add option `chrome_options.add_argument("--no-sandbox")` for chrome.
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
without --no-sandbox param, load documents from url by selenium in chrome occured error below: ```Traceback (most recent call last): File "/data//playgroud/try_langchain.py", line 343, in <module> langchain_doc_loader() File "/data//playgroud/try_langchain.py", line 67, in langchain_doc_loader documents = loader.load() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 102, in load driver = self._get_driver() File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/langchain/document_loaders/url_selenium.py", line 76, in _get_driver return Chrome(options=chrome_options) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 80, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 104, in __init__ super().__init__( File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 286, in __init__ self.start_session(capabilities, browser_profile) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 378, in start_session response = self.execute(Command.NEW_SESSION, parameters) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 440, in execute self.error_handler.check_response(response) File "/install/anaconda3-env/envs/python3.10/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.WebDriverException: Message: unknown error: Chrome failed to start: exited abnormally. (unknown error: DevToolsActivePort file doesn't exist) (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) Stacktrace: #0 0x55cf8da1bfe3 <unknown> langchain-ai#1 0x55cf8d75ad36 <unknown> langchain-ai#2 0x55cf8d783b20 <unknown> langchain-ai#3 0x55cf8d77fa9b <unknown> langchain-ai#4 0x55cf8d7c1af7 <unknown> langchain-ai#5 0x55cf8d7c111f <unknown> langchain-ai#6 0x55cf8d7b8693 <unknown> langchain-ai#7 0x55cf8d78b03a <unknown> langchain-ai#8 0x55cf8d78c17e <unknown> langchain-ai#9 0x55cf8d9dddbd <unknown> langchain-ai#10 0x55cf8d9e1c6c <unknown> langchain-ai#11 0x55cf8d9eb4b0 <unknown> langchain-ai#12 0x55cf8d9e2d63 <unknown> langchain-ai#13 0x55cf8d9b5c35 <unknown> langchain-ai#14 0x55cf8da06138 <unknown> langchain-ai#15 0x55cf8da062c7 <unknown> langchain-ai#16 0x55cf8da14093 <unknown> langchain-ai#17 0x7f3da31a72de start_thread ``` add option `chrome_options.add_argument("--no-sandbox")` for chrome.
baskaryan
pushed a commit
that referenced
this pull request
Oct 6, 2023
Prince-Mendiratta
pushed a commit
to Prince-Mendiratta/langchain
that referenced
this pull request
Oct 17, 2023
…_docs Update callback docs to reflect proper JS behavior
srics
pushed a commit
to srics/langchain
that referenced
this pull request
Feb 1, 2024
Update unit test for lazy_load. Format code using ruff.
4 tasks
hwchase17
pushed a commit
that referenced
this pull request
Mar 19, 2024
…e `text-splitter` directory is copied before poetry installation (#19214) ## Description This PR modifies the settings in `libs/langchain/dev.Dockerfile` to ensure that the `text-splitters` directory is copied before the poetry installation process begins. Without this modification, the `docker build` command fails for `dev.Dockerfile`, preventing the setup of some development environments, including `.devcontainer`. ## Bug Details ### Repro Run the following command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The docker build command fails, raising the following error: ``` ... => [langchain-dev-dependencies 4/5] COPY libs/community/ ../community/ 0.4s => ERROR [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 1.1s ------ > [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs: #13 0.970 #13 0.970 Directory ../text-splitters does not exist ------ executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` ### Expected Behavior The `docker build` command successfully completes without the poetry error. ### Analysis The error occurs because the `text-splitters` directory is not copied into the build environment, unlike the other packages under the `libs` directory. I suspect that the `COPY` setting was overlooked since `text-splitters` was separated in a recent PR. ## Fix Add the following lines to the `libs/langchain/dev.Dockerfile`: ```dockerfile # Copy the text-splitters library for installation COPY libs/text-splitters/ ../text-splitters/ ```
gkorland
referenced
this pull request
in FalkorDB/langchain
Mar 30, 2024
…e `text-splitter` directory is copied before poetry installation (langchain-ai#19214) ## Description This PR modifies the settings in `libs/langchain/dev.Dockerfile` to ensure that the `text-splitters` directory is copied before the poetry installation process begins. Without this modification, the `docker build` command fails for `dev.Dockerfile`, preventing the setup of some development environments, including `.devcontainer`. ## Bug Details ### Repro Run the following command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The docker build command fails, raising the following error: ``` ... => [langchain-dev-dependencies 4/5] COPY libs/community/ ../community/ 0.4s => ERROR [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 1.1s ------ > [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs: #13 0.970 #13 0.970 Directory ../text-splitters does not exist ------ executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` ### Expected Behavior The `docker build` command successfully completes without the poetry error. ### Analysis The error occurs because the `text-splitters` directory is not copied into the build environment, unlike the other packages under the `libs` directory. I suspect that the `COPY` setting was overlooked since `text-splitters` was separated in a recent PR. ## Fix Add the following lines to the `libs/langchain/dev.Dockerfile`: ```dockerfile # Copy the text-splitters library for installation COPY libs/text-splitters/ ../text-splitters/ ```
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this pull request
Mar 30, 2024
…e `text-splitter` directory is copied before poetry installation (langchain-ai#19214) ## Description This PR modifies the settings in `libs/langchain/dev.Dockerfile` to ensure that the `text-splitters` directory is copied before the poetry installation process begins. Without this modification, the `docker build` command fails for `dev.Dockerfile`, preventing the setup of some development environments, including `.devcontainer`. ## Bug Details ### Repro Run the following command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The docker build command fails, raising the following error: ``` ... => [langchain-dev-dependencies 4/5] COPY libs/community/ ../community/ 0.4s => ERROR [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 1.1s ------ > [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs: langchain-ai#13 0.970 langchain-ai#13 0.970 Directory ../text-splitters does not exist ------ executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` ### Expected Behavior The `docker build` command successfully completes without the poetry error. ### Analysis The error occurs because the `text-splitters` directory is not copied into the build environment, unlike the other packages under the `libs` directory. I suspect that the `COPY` setting was overlooked since `text-splitters` was separated in a recent PR. ## Fix Add the following lines to the `libs/langchain/dev.Dockerfile`: ```dockerfile # Copy the text-splitters library for installation COPY libs/text-splitters/ ../text-splitters/ ```
shane-huang
added a commit
to shane-huang/langchain
that referenced
this pull request
Apr 25, 2024
fix breaking change in interface
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…e `text-splitter` directory is copied before poetry installation (#19214) ## Description This PR modifies the settings in `libs/langchain/dev.Dockerfile` to ensure that the `text-splitters` directory is copied before the poetry installation process begins. Without this modification, the `docker build` command fails for `dev.Dockerfile`, preventing the setup of some development environments, including `.devcontainer`. ## Bug Details ### Repro Run the following command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The docker build command fails, raising the following error: ``` ... => [langchain-dev-dependencies 4/5] COPY libs/community/ ../community/ 0.4s => ERROR [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 1.1s ------ > [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs: #13 0.970 #13 0.970 Directory ../text-splitters does not exist ------ executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` ### Expected Behavior The `docker build` command successfully completes without the poetry error. ### Analysis The error occurs because the `text-splitters` directory is not copied into the build environment, unlike the other packages under the `libs` directory. I suspect that the `COPY` setting was overlooked since `text-splitters` was separated in a recent PR. ## Fix Add the following lines to the `libs/langchain/dev.Dockerfile`: ```dockerfile # Copy the text-splitters library for installation COPY libs/text-splitters/ ../text-splitters/ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.