Merge pull request langchain-ai#13 from shane-huang/llm-gpu

fix breaking change in interface
shane-huang · Apr 25, 2024 · dbccebd · dbccebd
2 parents 60e6ff6 + 2d842f0
commit dbccebd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/libs/community/langchain_community/llms/bigdl_llm.py b/libs/community/langchain_community/llms/bigdl_llm.py
@@ -22,10 +22,11 @@ class BigdlLLM(IpexLLM):
     def from_model_id(
         cls,
         model_id: str,
+        model_kwargs: Optional[dict] = None,
+        *,
         tokenizer_id: Optional[str] = None,
         load_in_4bit: bool = True,
         load_in_low_bit: Optional[str] = None,
-        model_kwargs: Optional[dict] = None,
         **kwargs: Any,
     ) -> LLM:
         """
@@ -105,8 +106,9 @@ def from_model_id(
     def from_model_id_low_bit(
         cls,
         model_id: str,
-        tokenizer_id: Optional[str] = None,
         model_kwargs: Optional[dict] = None,
+        *,
+        tokenizer_id: Optional[str] = None,
         **kwargs: Any,
     ) -> LLM:
         """

diff --git a/libs/community/langchain_community/llms/ipex_llm.py b/libs/community/langchain_community/llms/ipex_llm.py
@@ -41,10 +41,11 @@ class Config:
     def from_model_id(
         cls,
         model_id: str,
+        model_kwargs: Optional[dict] = None,
+        *,
         tokenizer_id: Optional[str] = None,
         load_in_4bit: bool = True,
         load_in_low_bit: Optional[str] = None,
-        model_kwargs: Optional[dict] = None,
         **kwargs: Any,
     ) -> LLM:
         """
@@ -82,8 +83,9 @@ def from_model_id(
     def from_model_id_low_bit(
         cls,
         model_id: str,
-        tokenizer_id: Optional[str] = None,
         model_kwargs: Optional[dict] = None,
+        *,
+        tokenizer_id: Optional[str] = None,
         **kwargs: Any,
     ) -> LLM:
         """