Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[minor],community[patch],standard-tests[patch]: Move InMemoryImplementation to langchain-core #23986

Merged
merged 7 commits into from
Jul 8, 2024
Merged

core[minor],community[patch],standard-tests[patch]: Move InMemoryImplementation to langchain-core #23986

merged 7 commits into from
Jul 8, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Jul 8, 2024

This PR moves the in memory implementation to langchain-core.

  • The implementation remains importable from langchain-community.
  • Supporting utilities are marked as private for now.

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 9:03pm

@eyurtsev eyurtsev requested a review from efriis July 8, 2024 20:30
@eyurtsev eyurtsev mentioned this pull request Jul 8, 2024
Closed
@eyurtsev eyurtsev marked this pull request as ready for review July 8, 2024 21:08
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. community Related to langchain-community Ɑ: core Related to langchain-core Ɑ: vector store Related to vector store module 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Jul 8, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 8, 2024
@efriis efriis merged commit f765e8f into master Jul 8, 2024
238 checks passed
@efriis efriis deleted the eugene/in_memory_vectorstore_core branch July 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:XL This PR changes 500-999 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyurtsev @efriis