-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: added FakeVectorStore #9293
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@eyurtsev @hwchase17 could you take a look, please? |
@baskaryan Could you, please, review it? It looks like very helpful addition. |
out of curiosity how are you imagining using this? |
@baskaryan I find it useful to use together with a FakeLLM (and a callback). It makes it possible to write unit tests to test custom chains. Does it make sense? |
@lkuligin if you want to write some unit tests for some of the in-library chains and runnables, it might demonstrate the use case a bit better. Otherwise, I'll probably close this, and you can continue using it in your codebase for unit testing custom chains! |
We also have plenty Fake classes: LLM, Embeddings. It makes sense to make Fake classes for all modules. So, I like this Fake vector store. |
Thanks for this @lkuligin, I was able to use this in combination with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the in memory vectorstore into core! It relies on numpy, but we can make it into an optional dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to core!
Here's a PR that should resolve this issue: #23986 |
Closing this as we merged the in memory vectorstore |
#9292