-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init embeddings #28370
Merged
Merged
Init embeddings #28370
+380
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hinthornw
force-pushed
the
wfh/init_embeddings
branch
2 times, most recently
from
November 26, 2024 22:33
3a75d7a
to
497fa34
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
Ɑ: embeddings
Related to text embedding models module
labels
Nov 26, 2024
hinthornw
force-pushed
the
wfh/init_embeddings
branch
from
November 26, 2024 22:52
497fa34
to
37a104f
Compare
baskaryan
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slick
hinthornw
force-pushed
the
wfh/init_embeddings
branch
3 times, most recently
from
November 27, 2024 06:15
5c1fc9f
to
7a067bc
Compare
hinthornw
force-pushed
the
wfh/init_embeddings
branch
from
November 27, 2024 06:20
7a067bc
to
5fb09ef
Compare
baskaryan
approved these changes
Nov 27, 2024
f"Supported providers are: {', '.join(providers)}" | ||
) | ||
|
||
return _init_embeddings_helper(model, provider=provider, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubernit, helper doesn't really feel needed here
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ɑ: embeddings
Related to text embedding models module
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.