Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init embeddings #28370

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Init embeddings #28370

merged 3 commits into from
Nov 27, 2024

Conversation

hinthornw
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:22am

@hinthornw hinthornw force-pushed the wfh/init_embeddings branch 2 times, most recently from 3a75d7a to 497fa34 Compare November 26, 2024 22:33
@hinthornw hinthornw marked this pull request as ready for review November 26, 2024 22:45
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module labels Nov 26, 2024
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick

libs/langchain/langchain/embeddings/base.py Outdated Show resolved Hide resolved
libs/langchain/langchain/embeddings/base.py Outdated Show resolved Hide resolved
libs/langchain/langchain/embeddings/base.py Outdated Show resolved Hide resolved
@hinthornw hinthornw force-pushed the wfh/init_embeddings branch 3 times, most recently from 5c1fc9f to 7a067bc Compare November 27, 2024 06:15
f"Supported providers are: {', '.join(providers)}"
)

return _init_embeddings_helper(model, provider=provider, **kwargs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubernit, helper doesn't really feel needed here

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 27, 2024
@hinthornw hinthornw enabled auto-merge (squash) November 27, 2024 08:22
@hinthornw hinthornw merged commit 585da22 into master Nov 27, 2024
31 checks passed
@hinthornw hinthornw deleted the wfh/init_embeddings branch November 27, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants