feat: ✨ Added filtering option to FAISS vectorstore #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by the filtering capability available in ChromaDB, added the same functionality to FAISS vectorestore aswell. Since FAISS does not have an inbuilt method of filtering used the approach suggested in this thread facebookresearch/faiss#1079 fix: 🧪 Removed FAISS vectorestore testcase from unit tests as the git actions were failing
refactor: 🚨 fixed line error in comments chore: 🚨 lint errors
hwchase17
reviewed
Jun 10, 2023
refactor: 🚨 Changed Typing Anotator for filters
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Inspired by the filtering capability available in ChromaDB, added the same functionality to the FAISS vectorestore as well. Since FAISS does not have an inbuilt method of filtering used the approach suggested in this [thread](facebookresearch/faiss#1079) Langchain Issue inspiration: langchain-ai#4572 - [x] Added filtering capability to semantic similarly and MMR - [x] Added test cases for filtering in `tests/integration_tests/vectorstores/test_faiss.py` #### Who can review? Tag maintainers/contributors who might be interested: VectorStores / Retrievers / Memory - @dev2049 - @hwchase17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the filtering capability available in ChromaDB, added the same functionality to the FAISS vectorestore as well. Since FAISS does not have an inbuilt method of filtering used the approach suggested in this thread
Langchain Issue inspiration: #4572
tests/integration_tests/vectorstores/test_faiss.pyWho can review?
Tag maintainers/contributors who might be interested:
VectorStores / Retrievers / Memory