Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ Added filtering option to FAISS vectorstore #5966

Merged
merged 3 commits into from
Jun 11, 2023
Merged

feat: ✨ Added filtering option to FAISS vectorstore #5966

merged 3 commits into from
Jun 11, 2023

Commits on Jun 10, 2023

  1. feat: ✨ Added filtering option to FAISS vectorstore 

    Inspired by the filtering capability available in ChromaDB, added the same functionality to FAISS vectorestore aswell. Since FAISS does not have an inbuilt method of filtering used the approach suggested in this thread facebookresearch/faiss#1079

fix: 🧪 Removed FAISS vectorestore testcase from unit tests as the git actions were failing
    @vempaliakhil96
    vempaliakhil96 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    251a401 View commit details
    Browse the repository at this point in the history

  2. chore: 🚨 fixed lint errors 

    refactor: 🚨 fixed line error in comments

chore: 🚨 lint errors
    @vempaliakhil96
    vempaliakhil96 committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2d417f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. refactor: 📝 Updated documentation as per suggestion on PR 

    refactor: 🚨 Changed Typing Anotator for filters
    @vempaliakhil96
    vempaliakhil96 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    838fc98 View commit details
    Browse the repository at this point in the history