community[minor]: Improve Azure Cosmos DB vector store support #5197
Conversation
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -48,13 +48,18 @@ describe.skip("AzureCosmosDBVectorStore", () => { | |||
| process.env.AZURE_COSMOSDB_CONNECTION_STRING! | |||
There was a problem hiding this comment.
Hey there! I've reviewed the code and noticed that the recent changes explicitly access an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable handling practices. Let me know if you have any questions or need further clarification.
| similarity: AzureCosmosDBSimilarityType = AzureCosmosDBSimilarityType.COS | ||
| ): Promise<void> { | ||
| await this.initPromise; | ||
| await this.connectPromise; |
There was a problem hiding this comment.
If this is hypothetically called before connectPromise is initialized, could we throw instead?
There was a problem hiding this comment.
Ah never mind, I see below. Could we always just rely on this.initPromise instead?
There was a problem hiding this comment.
Since init calls createIndex we need 2 different promise there otherwise there's an interlocking:
- connectPromise => create DB + collections clients
- initPromise => connectPromise + createIndex
There was a problem hiding this comment.
For the throw question, the issue is that the promise is created in the constructor and there's no way for the user to wait for it or know when the connect task is done.
sinedied
force-pushed
the
azure-mongo-update
branch
from
857756b to
4055993
Compare
…azure-mongo-update
jacoblee93
added
lgtm
|
Thank you! |
* core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one (#5342) * core: RunnableLambda should consume async iterator if the wrapped function returns one * Consume iterators too * Add tests * Dont interpret arrays/sets/etc as iterators * Implement in invoke too * Fix async storage propagation * Handle any async iterable * Add more tests * community[minor]: Improve Azure Cosmos DB vector store support (#5197) * feat: add delete by filter * feat: return added document ids * fix: delete by id * test: update integration tests * feat: add automatic index creation * Update azure_cosmosdb.ts * refactor: separate ids and filter params for delete() * refactor: use a single param for delete * test: fix unit tests * Address feedback --------- Co-authored-by: Jacob Lee <jacoblee93@gmail.com> * Revert "Merge branch 'v0.1' into main" (#5345) This reverts commit db5ab3f, reversing changes made to 2b3b194. --------- Co-authored-by: Nuno Campos <nuno@boringbits.io> Co-authored-by: Yohan Lasorsa <noda@free.fr> Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
This PR improves the existing Azure Cosmos DB vector store in the following ways:
It does not include any breaking changes.