-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction returns one
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dqbd
reviewed
May 13, 2024
dqbd
approved these changes
May 13, 2024
Thank you! |
bracesproul
added a commit
that referenced
this pull request
May 13, 2024
* core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one (#5342) * core: RunnableLambda should consume async iterator if the wrapped function returns one * Consume iterators too * Add tests * Dont interpret arrays/sets/etc as iterators * Implement in invoke too * Fix async storage propagation * Handle any async iterable * Add more tests * community[minor]: Improve Azure Cosmos DB vector store support (#5197) * feat: add delete by filter * feat: return added document ids * fix: delete by id * test: update integration tests * feat: add automatic index creation * Update azure_cosmosdb.ts * refactor: separate ids and filter params for delete() * refactor: use a single param for delete * test: fix unit tests * Address feedback --------- Co-authored-by: Jacob Lee <jacoblee93@gmail.com> * Revert "Merge branch 'v0.1' into main" (#5345) This reverts commit db5ab3f, reversing changes made to 2b3b194. --------- Co-authored-by: Nuno Campos <nuno@boringbits.io> Co-authored-by: Yohan Lasorsa <noda@free.fr> Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
lgtm
PRs that are ready to be merged as-is
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)