Skip to content

fix: fix enhance app mode check#30758

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30757
Jan 9, 2026
Merged

fix: fix enhance app mode check#30758
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30757

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 9, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30757

enhance app mode check in app list page

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's handling of app mode parameters, addressing potential inconsistencies and errors that could arise from invalid or legacy URL query strings. By implementing both client-side normalization and server-side validation, the changes ensure a more robust and predictable user experience when navigating app lists, preventing unexpected behavior due to malformed mode specifications.

Highlights

  • Client-side App Mode Validation: Implemented client-side logic in the app list page to validate and normalize app mode query parameters. This ensures that legacy or invalid mode parameters are correctly converted to category or defaulted to 'all', improving URL handling robustness.
  • Server-side App Mode Sanitization: Introduced server-side validation within the use-apps.ts service to sanitize app mode parameters before API requests. This prevents invalid modes from being processed by the backend, enhancing data integrity and preventing unexpected behavior.
  • Import Refactoring: Refactored the import statement for AppModeEnum in use-apps.ts for better code organization and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the app mode checking on the app list page. It introduces logic to handle legacy mode query parameters by migrating them to a category parameter and ensures that only valid categories are used for filtering. The changes also include backend validation for the app mode. The code is generally well-structured, but there are a few areas for improvement regarding React hook dependencies and code consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when Marketplace to studio, has some error

2 participants

Comments