-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: correctly delete applications using Celery workers #5787
Conversation
cc. @crazywoola |
Thank you for your PR! Could you please open an issue first, providing a detailed description of the problem, and include the issue link in this PR? This will help us quickly understand and review your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have a few questions. Please check the comments I left in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you.
Description
This PR implements a robust application deletion process using Celery workers. The change ensures that app deletion is handled asynchronously, improving system reliability and laying the groundwork for better user experience. It includes the deletion of all related data, including tag bindings.
However, more work is needed to implement polling or WebSocket for actual front-end status updates. This PR focuses on the backend implementation and prepares the system for future frontend enhancements.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes