Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync delete app table record when delete app #5819

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Jul 1, 2024

Description

sync delete app table record when delete app

Fixes #5787

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@JohnJyong JohnJyong requested a review from takatost July 1, 2024 10:30
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐍 python labels Jul 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@crazywoola crazywoola requested a review from laipz8200 July 1, 2024 12:36
Copy link
Collaborator

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! My bad.

@crazywoola crazywoola merged commit af308b9 into main Jul 2, 2024
8 checks passed
@crazywoola crazywoola deleted the fix/delete-app-logic branch July 2, 2024 00:48
ZhouhaoJiang added a commit that referenced this pull request Jul 2, 2024
* refs/heads/feat/add-permission:
  feat: add export permission
  chore: Update some type hints in config. (#5833)
  sync delete app table record when delete app (#5819)
  chore: update i18n for #5811 (#5838)
  Chore/remove extra docker middleware variables (#5836)
  Fix/docker nginx https config (#5832)
  add provision scripts repo link for azure to readme (#5820)
  Enhance: tools wecom bot support markdown message (#5791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants