Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: knowledge used by app can still be removed #5811

Merged
merged 4 commits into from
Jul 1, 2024
Merged

feat: knowledge used by app can still be removed #5811

merged 4 commits into from
Jul 1, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Jul 1, 2024

Description

Knowledge used by app can still be removed.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@iamjoel iamjoel requested a review from zxhlyh July 1, 2024 08:02
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Jul 1, 2024
zxhlyh
zxhlyh previously approved these changes Jul 1, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@zxhlyh zxhlyh self-requested a review July 1, 2024 08:10
@iamjoel iamjoel merged commit 78d41a2 into main Jul 1, 2024
6 checks passed
@iamjoel iamjoel deleted the feat/bind-knowledge-app-can-still-be-removed branch July 1, 2024 08:14
ZuzooVn added a commit to ZuzooVn/dify that referenced this pull request Jul 1, 2024
@ZuzooVn
chore: update i18n for langgenius#5811
01abcd2
@ZuzooVn ZuzooVn mentioned this pull request Jul 1, 2024
Merged
5 tasks
crazywoola pushed a commit that referenced this pull request Jul 2, 2024
@ZuzooVn
chore: update i18n for #5811 (#5838)
49d9c60
ZhouhaoJiang added a commit that referenced this pull request Jul 2, 2024
@ZhouhaoJiang
Merge branch 'refs/heads/feat/add-permission' into deploy/dev
b80dce6 
* refs/heads/feat/add-permission:
  feat: add export permission
  chore: Update some type hints in config. (#5833)
  sync delete app table record when delete app (#5819)
  chore: update i18n for #5811 (#5838)
  Chore/remove extra docker middleware variables (#5836)
  Fix/docker nginx https config (#5832)
  add provision scripts repo link for azure to readme (#5820)
  Enhance: tools wecom bot support markdown message (#5791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxhlyh zxhlyh zxhlyh approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamjoel @zxhlyh