Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BM4D #263

Merged
merged 28 commits into from
Mar 25, 2022
Merged

Add BM4D #263

merged 28 commits into from
Mar 25, 2022

Conversation

smajee
Copy link
Contributor

@smajee smajee commented Mar 24, 2022

  • Add BM4D with tests and an example (closes issue Add BM4D #183)
  • Fix minor bug in BM3D tests

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #263 (e7878b9) into main (31797e2) will decrease coverage by 0.03%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   93.75%   93.72%   -0.04%     
==========================================
  Files          50       50              
  Lines        3636     3681      +45     
==========================================
+ Hits         3409     3450      +41     
- Misses        227      231       +4     
Flag Coverage Δ
unittests 93.72% <91.30%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/denoiser.py 89.02% <82.60%> (-2.51%) ⬇️
scico/examples.py 95.87% <100.00%> (+0.75%) ⬆️
scico/functional/__init__.py 100.00% <100.00%> (ø)
scico/functional/_denoiser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31797e2...e7878b9. Read the comment docs.

@smajee smajee requested review from bwohlberg and Michael-T-McCann and removed request for Michael-T-McCann March 24, 2022 03:09
scico/examples.py Outdated Show resolved Hide resolved
scico/examples.py Outdated Show resolved Hide resolved
scico/examples.py Outdated Show resolved Hide resolved
scico/denoiser.py Outdated Show resolved Hide resolved
@bwohlberg
Copy link
Collaborator

Note the reasonably significant coverage reduction, which should be addressed.

scico/examples.py Outdated Show resolved Hide resolved
scico/examples.py Outdated Show resolved Hide resolved
@bwohlberg
Copy link
Collaborator

Docs build issue seems to be resolved by temporary fix. Reduced coverage is the only remaining CI failure.

scico/examples.py Outdated Show resolved Hide resolved
scico/examples.py Outdated Show resolved Hide resolved
scico/examples.py Outdated Show resolved Hide resolved
@bwohlberg
Copy link
Collaborator

Looking good: just a few minor issues remaining before it's ready for merging.

Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the trivial -0.04% coverage drop can be ignored. The only remaining unaddressed comment I see is w.r.t. rho tuning in the example script. Probably worth giving that some brief attention if you haven't already, but I'm approving the PR anyway.

@smajee smajee merged commit f0758ea into main Mar 25, 2022
@smajee smajee deleted the smajee/bm4d branch March 25, 2022 19:10
@smajee smajee restored the smajee/bm4d branch March 25, 2022 19:18
@smajee smajee deleted the smajee/bm4d branch March 25, 2022 22:38
@smajee smajee mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants