-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BM4D #263
Add BM4D #263
Conversation
smajee
commented
Mar 24, 2022
•
edited
Loading
edited
- Add BM4D with tests and an example (closes issue Add BM4D #183)
- Fix minor bug in BM3D tests
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 93.75% 93.72% -0.04%
==========================================
Files 50 50
Lines 3636 3681 +45
==========================================
+ Hits 3409 3450 +41
- Misses 227 231 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Note the reasonably significant coverage reduction, which should be addressed. |
Docs build issue seems to be resolved by temporary fix. Reduced coverage is the only remaining CI failure. |
Looking good: just a few minor issues remaining before it's ready for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the trivial -0.04% coverage drop can be ignored. The only remaining unaddressed comment I see is w.r.t. rho tuning in the example script. Probably worth giving that some brief attention if you haven't already, but I'm approving the PR anyway.