[BUG] module 'jinja2.utils' has no attribute 'escape'

[aiwalter]

Today released jinja2 version has deprecated jinja2.utils.escape.
See here: pallets/jinja#1626

Not directly, it raises on readthedocs when building docs from notebooks:
https://readthedocs.org/projects/sktime/builds/16457301/

Nbconvert version:
latest

[davidism]

nbconvert/nbconvert/filters/ansi.py

Lines 50 to 61 in 1211cb2

	def ansi2html(text):
	"""
	Convert ANSI colors to HTML colors.
	Parameters
	----------
	text : unicode
	Text containing ANSI colors to convert to HTML
	"""
	text = jinja2.utils.escape(text)
	return _ansi2anything(text, _htmlconverter)

This needs to be changed to use from markupsafe import escape.

[aiwalter]

yes its this code, so actually it is coming from nbconvert package, right?

[aiwalter]

can you fix it, or should I make a PR? You would have to release it then ideally soon :)

[davidism]

I am not a maintainer of this package.

[mriedem]

We're also seeing this, not sure if it's related but I'm chalking it up to the new jinja2 3.1.0 release:

Traceback (most recent call last):

  File "/opt/conda/bin/jupyter-nbconvert", line 6, in <module>

    from nbconvert.nbconvertapp import main

  File "/opt/conda/lib/python3.8/site-packages/nbconvert/__init__.py", line 4, in <module>

    from .exporters import *

  File "/opt/conda/lib/python3.8/site-packages/nbconvert/exporters/__init__.py", line 3, in <module>

    from .html import HTMLExporter

  File "/opt/conda/lib/python3.8/site-packages/nbconvert/exporters/html.py", line 12, in <module>

    from jinja2 import contextfilter

ImportError: cannot import name 'contextfilter' from 'jinja2' (/opt/conda/lib/python3.8/site-packages/jinja2/__init__.py)

[davidism]

That one was addressed here: #1624.

It looks like #1637 was merged to treat warnings as errors in tests, which is good, although it didn't seem to catch these deprecation warnings.

[SylvainCorlay]

cc @MSeal @davidbrochart FYI

[davidism]

nbconvert/setup.cfg

Lines 12 to 14 in 1211cb2

	[tool:pytest]
	markers =
	network: marks tests which require network connection

If nbconvert adds filterwarnings = error to this section, they can respond proactively to warnings. The previous "warnings as errors" PR was only in relation to their own documentation builds.