update release issue template #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
approved these changes
Mar 28, 2022
|
Documentation CI still fails with: Notebook error:
[4911](https://github.com/neuronsimulator/nrn/runs/5709997468?check_suite_focus=true#step:7:4911)
AttributeError in rxd-tutorials/Reaction-Diffusion tutorial.ipynb:
[4912](https://github.com/neuronsimulator/nrn/runs/5709997468?check_suite_focus=true#step:7:4912)
module 'jinja2.utils' has no attribute 'escape'cc: @olupton |
|
They released a 3.1.1, so |
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 551 551
Lines 111225 111225
=======================================
Hits 50393 50393
Misses 60832 60832 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
alkino
reviewed
Mar 28, 2022
| @@ -11,5 +11,5 @@ plotnine | |||
| numpy | |||
| plotly | |||
| nbsphinx | |||
| # 3.1.0 is buggy | |||
| jinja2!=3.1.0 | |||
| # 3.1+ removed jinja2.utils.escape that is used by other tools | |||
|
Looks like The sad part is that we have already released and RTD build is not working at the moment. We will have to wait for upstream fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.