Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for first/last agg #1962

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fix for first/last agg #1962

merged 2 commits into from
Mar 25, 2022

Conversation

JovanVeljanoski
Copy link
Member

@JovanVeljanoski JovanVeljanoski commented Mar 8, 2022 •
edited by maartenbreddels
Loading

first / last aggregators raise and exception if the expression they are operating on is more than a single character.

First exposed in #1848 (comment).

  • Expose problem as a test
  • Make test pass

@JovanVeljanoski JovanVeljanoski mentioned this pull request Mar 16, 2022
Closed
@maartenbreddels
Copy link
Member

Failures only seem to be nbconvert related, see jupyter/nbconvert#1736

@maartenbreddels maartenbreddels merged commit 17ccdbd into master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maartenbreddels maartenbreddels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JovanVeljanoski @maartenbreddels