Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Improvements for SessionGuard methods loginUsingId and onceUsingId #13393

Merged
merged 6 commits into from
May 2, 2016
Merged

[5.2] Improvements for SessionGuard methods loginUsingId and onceUsingId #13393

merged 6 commits into from
May 2, 2016

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented May 1, 2016

Follow-up to #12999.

  • Remove redundant session set, as I explained in this message.
  • If loginUsingId didn't find user, don't try to login and return false, instead of producing a load of errors. Note how well it is consistent with onceUsingId.
  • Improve test coverage.

@vlakoff vlakoff mentioned this pull request May 1, 2016
Closed
@taylorotwell taylorotwell merged commit 83a4b3f into laravel:5.2 May 2, 2016
@taylorotwell
Copy link
Member

Thanks.

@vlakoff
Copy link
Contributor Author

vlakoff commented May 2, 2016

For consistency, maybe both loginUsingId and onceUsingId should return user instance in 5.3?

@vlakoff
Copy link
Contributor Author

vlakoff commented May 3, 2016

Refs #8836 which fixed onceUsingId for missing user case, but not loginUsingId.

@vlakoff vlakoff deleted the auth-guard-2 branch May 6, 2016 04:41
@vlakoff
Copy link
Contributor Author

vlakoff commented Aug 3, 2016

Refs #13434 which has unified loginUsingId and onceUsingId return values in 5.3, per my above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlakoff @taylorotwell